So, sometimes guys think that they have her best intentions in mind when bringing a gift,  but in the history of the hobby there have been some lame, disgusting and rather extravagant gifts given.

If so, I could see her point.  Actually, I've eaten at Subway; she is well justified.
 

A provider gave you a gift? Wow!!!

I have received gifts from providers many times over the years.

When someone is touring, keep the gifts small and light. A bottle of booze is hard to pack (and TSA might want to taste and confiscate it) and takes up room in a stuffed bag. She will either have to drink before leaving or, don't be offended, re-gift it to someone else, maybe a local client, or leave it in the room for the hotel staff.  
.
Even clothing, if larger than a couple of band-aids, can be hard to cram into a traveler's suitcase.  
.  
Jewelry (mrfisher's thing) is small, light and can even be worn in transit.
.
I have been left holding the bag, so to speak, on a few occasions, and had to get rid of those items in a hurry before heading off to meetings and other obligations. You can bring a "toy" to a Provider but you get NCNSed you can't just bring that same to a family gathering later that evening. Into the garbage and hope that some homeless person finds it and makes good use of it.

thrift store.

a candle holder made from rough rose quartz for a tantrika escort of mine.

but there it was in all its smelly glory.

... I've bought my ATF several gifts over the years, including two vibes. The first one was a model I knew she really liked, and she loved it because she wanted a second one (one for home, one for her incall).  The second one was well-intended, but proves it's not a good idea to give a personal gift unless you're sure the recipient will like it. I read about a vibe that supposedly is good for women with sensitive clits, which my ATF has.  It doesn't actually touch the clit, but envelops it and caresses it with air pressure.  So I got one for her. She was very appreciative when I gave it to her, but when I asked her later how it worked for her, she said she couldn't get the hang of it, so she gave it to one of her provider friends (whom I've met a few times).  But she really loved it, so at least it eventually found a good home.  

I've brought back a few small gifts from my trips to Australia. Also flowers and clothes from wish lists.  

I had a client who was always giving me his wife's cast offs...an ugly tea set with pictures of chickens on them, ugly used purses and make up bags...ect.  The only thing I liked was an estee lauder gift set I guess she never used and I really only liked the mascara.  The rest went into my useless pile of junk because I'm too polite to refuse a gift.

The tackiest thing I have ever heard.  But I applaud your pragmatism in not getting pissed and kicking him to the curb.  A regular is  regular.  

The best gift for a regular is jewelry, but it must be the real deal and not costume jewelry that turns her skin green if she wears it in the shower.  Sex toys are part of the "tools of her trade", as is lingerie, so I try to give gifts that are more personal and not connected with, or that remind her of, her work.  To me, these are pretty lame and unimaginative.  If Jewelry is too pricey, then I would suggest concert tickets or gift cards to her store of choice.  

You seem to have more problems with TSA than terrorists  LOL

I spoke to a lady who had a client who would leave her bible tracts. What???

Got to her room and put the money on her credenza.  She said, "I've got an envelope for you!" and handed me an 8X10" manilla envelope.  I opened it and pulled out a charming professional shot of her sticking out her ass and pussy, signed personally to me.

Carlos the Jackal.

Aroma candles as a housewarming gift. I love them and the aroma fills the apartment thoroughly . The scents were just what I like. I still have a few left but i just use them for decoration. Of course these were not B&BW nor Glade.

in Japan, I had a regular who always brought me watches. None were particularly valuable, but I thought it was cute that I always got them. Another used to give me something from Tiffany each time he came. Not big, extravagant things, but small little trinkets and perfume. I also received pearls, makeup, lingerie, etc. there.

I once got a favorite that same clit vibrator, and as far as I know, she hasn't tried it yet. We didn't use it on that date because it would have taken too long to charge up. That is probably my lamest gift that I have given so far. I gave that same provider a tupperware of my homemade salsa, and she loved that.